Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torch 1.0.1 #27

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Torch 1.0.1 #27

wants to merge 40 commits into from

Conversation

belerico
Copy link

No description provided.

@sidharthms
Copy link
Collaborator

You have put in some great work! :) We recently updated the package for PyTorch v1.3, if there are certain features that you think may be useful to all users of deepmatcher, it'll be great if you could create more modular pull requests for specific components, I'll be happy to merge them to master.

@belerico
Copy link
Author

belerico commented Jan 12, 2020

You have put in some great work! :) We recently updated the package for PyTorch v1.3, if there are certain features that you think may be useful to all users of deepmatcher, it'll be great if you could create more modular pull requests for specific components, I'll be happy to merge them to master.

Thank you very much!
I really think that a big improvement would be to allow users to load a dataset directly as a Pandas.DataFrame instead of loading it from csv files. I've already done some work but it's still incomplete and it's a kind of hard fix.
Another useful improvement would be the possibility to load a self-pretrained embeddings; as for the above suggestion, I've done something, but it's a hard fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants